Re: [PATCH] x86/mce: add support SRAO reported via CMC check

From: Xie XiuQi
Date: Tue Nov 14 2017 - 20:43:37 EST


Hi Tony,

On 2017/11/15 2:51, Luck, Tony wrote:
> On Tue, Nov 14, 2017 at 01:55:11PM +0800, Xie XiuQi wrote:
>> + /* known AO MCACODs reported via CMC: */
>> + MCESEV(
>> + AO, "Action optional: memory scrubbing error",
>> + SER, MASK(MCI_UC_SAR|MCACOD_SCRUBMSK, MCI_STATUS_UC|MCACOD_SCRUB)
>
> I think you should check for OVER=0 (as the existing AO cases do).
> If there was a patrol scrub reported by CMCI, and then another UC
> error, we can't safely treat this as an AO ... because we have no
> idea what the second UC error was.

OK, I'll add check for OVER=0 in v2.

--
Thanks,
Xie XiuQi

>
> -Tony
>
> .
>