Re: [PATCH v8 2/6] time: sync read_boot_clock64() with persistent clock

From: Dou Liyang
Date: Tue Nov 14 2017 - 21:50:16 EST


Hi Pavel,

At 11/15/2017 03:57 AM, Pavel Tatashin wrote:
why we should remove the *extern* keyword?

Hi Dou,

While, I am not sure why it was decided to stop using externs in
headers, this is a warning printed by scripts/checkpatch.pl:

CHECK: extern prototypes should be avoided in .h files

To have a clean checkpatch output I removed externs.


I see.

IMO, using the extern keyword on function prototypes in *.h files
is superfluous, but, It doesn't matter for functionality. *extern*
is default keywords.

AFAIK, it's a code style problem. In x86 arch, we prefer to
keep *extern* explicitly, so, let's keep it like before for
code consistency.

Thank,
dou