Re: [PATCH v4 1/1] xdp: Sample xdp program implementing ip forward

[Christina Jacob]

On Thu, Nov 9, 2017 at 7:08 AM, Jesper Dangaard Brouer
<brouer@xxxxxxxxxx> wrote:
> On Wed, 08 Nov 2017 10:40:24 +0900 (KST)
> David Miller <davem@xxxxxxxxxxxxx> wrote:
>
>> From: Christina Jacob <christina.jacob.koikara@xxxxxxxxx>
>> Date: Sun,  5 Nov 2017 08:52:30 +0530
>>
>> > From: Christina Jacob <Christina.Jacob@xxxxxxxxxx>
>> >
>> > Implements port to port forwarding with route table and arp table
>> > lookup for ipv4 packets using bpf_redirect helper function and
>> > lpm_trie  map.
>> >
>> > Signed-off-by: Christina Jacob <Christina.Jacob@xxxxxxxxxx>
>>
>> Applied to net-next, thank you.
>
> I've not had time to proper test (and review) this V4 patch, but I
> guess I'll have to do so when I get home from Seoul...
>
> I especially want to measure the effect of using bpf_redirect_map().
> To Christina: what performance improvement did you see on your
> board/arch when switching from bpf_redirect() to bpf_redirect_map()?

ndo_xdp_flush is yet to be implemented in our driver.
So I don't see any difference moving from bpf_redirect to bpf_redirect_map.

>
> --
> Best regards,
>   Jesper Dangaard Brouer
>   MSc.CS, Principal Kernel Engineer at Red Hat
>   LinkedIn: http://www.linkedin.com/in/brouer