Re: [PATCH] perf annotate: Remove precision for mnemonics

[Ravi Bangoria]

On 11/14/2017 06:34 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 14, 2017 at 08:55:40AM +0530, Ravi Bangoria escreveu:
> > There are many instructions, esp on powerpc, whose mnemonics are
> > longer than 6 characters. Using precision limit causes truncation
> > of such mnemonics.
> >
> > Fix this by removing precision limit. Note that, 'width' is still
> > 6, so alignment won't get affected for length <= 6.
> >
> > Before:
> >
> >     li     r11,-1
> >     xscvdp vs1,vs1
> >     add.   r10,r10,r11
> >
> > After:
> >
> >    li     r11,-1
> >    xscvdpsxds vs1,vs1
> >    add.   r10,r10,r11
> Ok, this improves the situation, as we stop truncating info, but I think
> that we should look for the longest instruction name and then use that
> to align the operands, will add that to my todo list if nobody does it
> first :-)

Hmm.. I could see longest one of 15 characters (f.e. AESKEYGENASSIST)
by a quick glance over list of instructions for x86 and powerpc. Need
to check for other archs.

> Thanks, applied.

Thanks,
Ravi