Re: [PATCH 2/2] leds: lm3692x: Introduce LM3692x dual string driver

From: Pavel Machek
Date: Wed Nov 15 2017 - 08:01:12 EST


Hi!

> >> + ret = regmap_write(led->regmap, LM3692X_PWM_CTRL,
> >> + LM3692X_PWM_FILTER_100 | LM3692X_PWM_SAMP_24MHZ);
> >> + if (ret)
> >> + dev_err(&led->client->dev, "Failed programming PWM CTRL\n");
> >> +
> >> + ret = regmap_write(led->regmap, LM3692X_BOOST_CTRL,
> >> + LM3692X_BRHT_MODE_RAMP_MULTI |
> >> + LM3692X_BL_ADJ_POL |
> >> + LM3692X_RAMP_RATE_250us);
> >> + if (ret)
> >> + dev_err(&led->client->dev, "Failed programming BOOST CTRL\n");
> >> +
> >> + ret = regmap_write(led->regmap, LM3692X_AUTO_FREQ_HI, 0x00);
> >> + if (ret)
> >> + dev_err(&led->client->dev, "Failed programming AUTO HI FREQ\n");
> >
> > If something fails, is it wise to continue?

If something fails, is it wise to continue?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature