Re: [PATCH 4.4 06/56] dt-bindings: clockgen: Add compatible string for LS1012A

From: Ben Hutchings
Date: Wed Nov 15 2017 - 10:20:24 EST


On Wed, 2017-11-15 at 16:16 +0100, Greg Kroah-Hartman wrote:
> On Tue, Nov 14, 2017 at 03:46:10PM +0000, Ben Hutchings wrote:
> > On Mon, 2017-11-13 at 13:55 +0100, Greg Kroah-Hartman wrote:
> > > 4.4-stable review patch.ÂÂIf anyone has any objections, please
> > > let me
> > > know.
> > >
> > > ------------------
> > >
> > > From: Harninder Rai <harninder.rai@xxxxxxx>
> > >
> > >
> > > [ Upstream commit 73447f68d7b2bc1df870da88b0e21d2bc1afc025 ]
> > >
> > > Signed-off-by: Harninder Rai <harninder.rai@xxxxxxx>
> > > Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya@xxxxxxx>
> > > Acked-by: Rob Herring <robh@xxxxxxxxxx>
> > > Signed-off-by: Shawn Guo <shawnguo@xxxxxxxxxx>
> > > Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > ---
> > > ÂDocumentation/devicetree/bindings/clock/qoriq-clock.txt |ÂÂÂÂ1 +
> > > Â1 file changed, 1 insertion(+)
> > >
> > > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > > @@ -31,6 +31,7 @@ Required properties:
> > > Â * "fsl,t4240-clockgen"
> > > Â * "fsl,b4420-clockgen"
> > > Â * "fsl,b4860-clockgen"
> > > + * "fsl,ls1012a-clockgen"
> >
> > This isn't supported or used anywhere in 4.4, so it makes sense to
> > document it.
>
> It "does" or "does not" make sense?ÂÂShould I drop this patch?

Sorry, it does not make sense to document it so please drop this.

Ben.

--
Ben Hutchings
Software Developer, Codethink Ltd.