RE: [PATCH 4.4 06/56] dt-bindings: clockgen: Add compatible string for LS1012A

[Bhaskar Upadhaya]

-----Original Message-----
From: Greg Kroah-Hartman [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] 
Sent: Wednesday, November 15, 2017 8:46 PM
To: Ben Hutchings <ben.hutchings@xxxxxxxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx; stable@xxxxxxxxxxxxxxx; Harninder Rai <harninder.rai@xxxxxxx>; Bhaskar Upadhaya <bhaskar.upadhaya@xxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; Sasha Levin <alexander.levin@xxxxxxxxxxx>
Subject: Re: [PATCH 4.4 06/56] dt-bindings: clockgen: Add compatible string for LS1012A

On Tue, Nov 14, 2017 at 03:46:10PM +0000, Ben Hutchings wrote:
> On Mon, 2017-11-13 at 13:55 +0100, Greg Kroah-Hartman wrote:
> > 4.4-stable review patch.  If anyone has any objections, please let 
> > me know.
> > 
> > ------------------
> > 
> > From: Harninder Rai <harninder.rai@xxxxxxx>
> > 
> > 
> > [ Upstream commit 73447f68d7b2bc1df870da88b0e21d2bc1afc025 ]
> > 
> > Signed-off-by: Harninder Rai <harninder.rai@xxxxxxx>
> > Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya@xxxxxxx>
> > Acked-by: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Shawn Guo <shawnguo@xxxxxxxxxx>
> > Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > ---
> >  Documentation/devicetree/bindings/clock/qoriq-clock.txt |    1 +
> >  1 file changed, 1 insertion(+)
> > 
> > --- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > +++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
> > @@ -31,6 +31,7 @@ Required properties:
> >  	* "fsl,t4240-clockgen"
> >  	* "fsl,b4420-clockgen"
> >  	* "fsl,b4860-clockgen"
> > +	* "fsl,ls1012a-clockgen"
> 
> This isn't supported or used anywhere in 4.4, so it makes sense to 
> document it.

It "does" or "does not" make sense?  Should I drop this patch?
[Bhaskar]
	Hi Greg,
	"fsl,ls1012a-clockgen" is getting used in the file drivers/clk/clk-qoriq.c(kernel v4.14) as below.
	{
		.compat = "fsl,ls1012a-clockgen",
		.cmux_groups = {
			&ls1012a_cmux
		},
		.cmux_to_group = {
			0, -1
		},
		.pll_mask = 0x03,
	},

confused,

greg k-h