Re: [PATCH 4.4 14/56] dt-bindings: Add LEGO MINDSTORMS EV3 compatible specification

[alexander . levin]

On Wed, Nov 15, 2017 at 04:50:13PM +0100, Greg Kroah-Hartman wrote:
>On Wed, Nov 15, 2017 at 03:14:53PM +0000, Ben Hutchings wrote:
>> On Wed, 2017-11-15 at 16:08 +0100, Greg Kroah-Hartman wrote:
>> > On Tue, Nov 14, 2017 at 08:15:58PM +0000, Ben Hutchings wrote:
>> > > On Mon, 2017-11-13 at 13:55 +0100, Greg Kroah-Hartman wrote:
>> > > > 4.4-stable review patch.  If anyone has any objections, please
>> > > > let me
>> > > > know.
>> > > >
>> > > > ------------------
>> > > >
>> > > > From: David Lechner <david@xxxxxxxxxxxxxx>
>> > > >
>> > > >
>> > > > [ Upstream commit 21078ab174c99885ca83a5c32db0d33b1617745e ]
>> > > >
>> > > > This adds the board level device tree specification for LEGO
>> > > > MINDSTORMS EV3
>> > >
>> > > Nothing uses or implements this in 4.4.
>> >
>> > Really?
>> >
>> > >
>> > > Ben.
>> > >
>> > > > Acked-by: Rob Herring <robh@xxxxxxxxxx>
>> > > > Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>
>> > > > Signed-off-by: Sekhar Nori <nsekhar@xxxxxx>
>> > > > Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
>> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> > > > ---
>> > > >  Documentation/devicetree/bindings/arm/davinci.txt |    4 ++++
>> > > >  1 file changed, 4 insertions(+)
>> > > >
>> > > > --- a/Documentation/devicetree/bindings/arm/davinci.txt
>> > > > +++ b/Documentation/devicetree/bindings/arm/davinci.txt
>> > > > @@ -9,6 +9,10 @@ EnBW AM1808 based CMC board
>> > > >  Required root node properties:
>> > > >      - compatible = "enbw,cmc", "ti,da850;
>> > > >  
>> > > > +LEGO MINDSTORMS EV3 (AM1808 based)
>> > > > +Required root node properties:
>> > > > +    - compatible = "lego,ev3", "ti,da850";
>> >
>> > I see lots of "ti,da850" dt stuff used in 4.4.  As this hardware was
>> > released on 3.2 or so, shouldn't this all be well-used by now?
>>
>> "ti,da850" is used but "lego,ev3" is not.
>
>Ugh, same for 4.9-stable as well.
>
>Sasha, can you send me a 'revert' patch for this, I applied it there
>already :(
>
>I'll go drop this from the 4.4 queue, thanks again Ben for your great
>review.

Sure. I'll also stop sending dt commits until I have a better story
for their selection process.

Thanks Ben!

-- 

Thanks,
Sasha