Re: [PATCH v3 1/2] dt: bindings: lm3692x: Add bindings for lm3692x LED driver

From: Dan Murphy
Date: Wed Nov 15 2017 - 15:32:46 EST


Jacek

On 11/15/2017 02:15 PM, Jacek Anaszewski wrote:
> Hi Dan,
>
> Thanks for the patch.
>
> On 11/15/2017 08:42 PM, Dan Murphy wrote:
>> This adds the devicetree bindings for the LM3692x
>> I2C LED string driver.
>>
>> Acked-by: Pavel Machek <pavel@xxxxxx>
>> Signed-off-by: Dan Murphy <dmurphy@xxxxxx>
>> ---
>>
>> v3 - No changes
>> v2 - No changes - https://patchwork.kernel.org/patch/10056677/
>>
>> .../devicetree/bindings/leds/leds-lm3692x.txt | 28 ++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3692x.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3692x.txt b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
>> new file mode 100644
>> index 000000000000..cfef67bd4100
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-lm3692x.txt
>> @@ -0,0 +1,28 @@
>> +* Texas Instruments - LM3692x Highly Efficient Dual-String White LED Driver
>> +
>> +The LM36922 is an ultra-compact, highly efficient,
>> +two string white-LED driver designed for LCD display
>> +backlighting.
>
> Shouldn't the driver be targeted for backlight subsystem then?
>
> Adding backlight maintainers.
>

Great point! I was not aware of the backlight subsystem.

Looks like I need to create a back light version as well.

Like the lp8788 did since this can be used as a LED driver beyond display back lighting.

Unless the maintainers don't want it.

Dan


--
------------------
Dan Murphy