[PATCH 1/3] fpga: fpga-mgr: remove unnecessary code in __fpga_mgr_get

From: Alan Tull
Date: Wed Nov 15 2017 - 17:34:08 EST


From: "Gustavo A. R. Silva" <garsilva@xxxxxxxxxxxxxx>

Notice that mgr = to_fpga_manager(dev); expands to:

mgr = container_of(dev, struct fpga_manager, dev);

and container_of is never null, so this null check is
unnecessary.

Addresses-Coverity-ID: 1397916
Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
Signed-off-by: Alan Tull <atull@xxxxxxxxxx>
---
drivers/fpga/fpga-mgr.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
index 1fd5494..0b7664d 100644
--- a/drivers/fpga/fpga-mgr.c
+++ b/drivers/fpga/fpga-mgr.c
@@ -412,8 +412,6 @@ static struct fpga_manager *__fpga_mgr_get(struct device *dev)
struct fpga_manager *mgr;

mgr = to_fpga_manager(dev);
- if (!mgr)
- goto err_dev;

if (!try_module_get(dev->parent->driver->owner))
goto err_dev;
--
2.7.4