Re: [PATCH] coccinelle: flags.cocci: reorganize patterns to improve efficiency

From: Julia Lawall
Date: Thu Nov 16 2017 - 02:31:36 EST

On Wed, 15 Nov 2017, Joe Perches wrote:

> On Wed, 2017-11-15 at 22:55 +0100, Julia Lawall wrote:
> > What version of Coccinelle do you have?
> > > I tried 1.0.4 and 1.0.6,
> > > but both failed.
> > For me, it also fails for 1.0.6. It should be OK for 1.0.7.
> Then likely this patch should not be applied or
> some form of local version checking should be done
> in the script itself.
> Scripts that use various tools are subject to
> language versioning requirements.
> For instance, there are many things that are
> possible with later versions of perl, but are not
> done for various scripts because many distributions
> do not ship with the latest versions.

It will say coccicheck failed if it is not compatible with the version of
Coccinelle. But it shouldn't break anything. We should put that it
requires 1.0.7, but I don't know if that is actually checked, or just
provided as documentation for the reader.