Re: [PATCH] net/smc: Fix preinitialization of buf_desc in __smc_buf_create()

[Arnd Bergmann]

On Thu, Nov 16, 2017 at 12:22 PM, Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> With gcc-4.1.2:
>
>     net/smc/smc_core.c: In function â__smc_buf_createâ:
>     net/smc/smc_core.c:567: warning: âbufsizeâ may be used uninitialized in this function
>
> Indeed, if the for-loop is never executed, bufsize is used
> uninitialized.  In addition, buf_desc is stored for later use, while it
> is still a NULL pointer.
>
> Before, error handling was done by checking if buf_desc is non-NULL.
> The cleanup changed this to an error check, but forgot to update the
> preinitialization of buf_desc to an error pointer.
>
> Update the preinitializatin of buf_desc to fix this.
>
> Fixes: b33982c3a6838d13 ("net/smc: cleanup function __smc_buf_create()")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> ---
> I don't know if this can ever happen, but the old code handled it.

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

This one I could reproduce with gcc-4.1 on x86, but not gcc-4.2 or higher.