Re: [PATCH] binder: fix proc->files use-after-free

From: Greg KH
Date: Thu Nov 16 2017 - 12:54:48 EST


On Thu, Nov 16, 2017 at 09:48:13AM -0800, Todd Kjos wrote:
> > @@ -875,22 +871,34 @@ static void binder_free_thread(struct binder_thread *thread);
> > static void binder_free_proc(struct binder_proc *proc);
> > static void binder_inc_node_tmpref_ilocked(struct binder_node *node);
> >
> > +struct files_struct *binder_get_files_struct(struct binder_proc *proc)
>
> This should be declared static:
> static struct files_struct *binder_get_files_struct(struct binder_proc *proc)
>
> Greg- should I send a "v2" for this?

Please do, I can't do anything with these until after 4.15-rc1 is out,
so you have time to do it :)

thanks,

greg k-h