drivers/net/wireless/broadcom/b43legacy/debugfs.c:224:23: error: implicit declaration of function 'debugfs_real_fops'

From: kbuild test robot
Date: Thu Nov 16 2017 - 20:16:03 EST

Next message:
Previous message: Next in thread: Messages sorted by:
tree: .config.gzDescription: application/gzip Miles Chen: "Re: [PATCH v4] dma-debug: fix incorrect pfn calculation" href="00860.html"> Yunlong Song: "[PATCH v3 RESEND] f2fs: add bug_on when f2fs_gc even fails to get one victim" href="00984.html"> Greg Kroah-Hartman: "Re: drivers/net/wireless/broadcom/b43legacy/debugfs.c:224:23: error: implicit declaration of function 'debugfs_real_fops'" href="date.html#00861">[ date ] [ thread ] [ subject ] [ author ] l.org/pub/scm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
r> debugfs: add support for more elaborate ->d_fsdata
as .config)
> 7b218db85bc
build tree
>>):

r> 7,
dcom/b43legacy/debugfs.c:26:
In function 'b43legacy_debugfs_read':
y/debugfs.c:224:23: error: implicit declaration of function 'debugfs_real_fops' [-Werror=implicit-function-declaration]

definition of macro 'container_of'
cast to pointer from integer of different size [-Wint-to-pointer-cast]
y/debugfs.c:224:10: note: in expansion of macro 'container_of'

:0,
dcom/b43legacy/debugfs.c:26:
invalid type argument of unary '*' (have 'int')
((type *)0)->member) && \
in definition of macro '__compiletime_assert'
in expansion of macro '_compiletime_assert'
__compiletime_assert_, __LINE__)
in expansion of macro 'compiletime_assert'
e_assert(!(cond), msg)
~~~~~~~~
expansion of macro 'BUILD_BUG_ON_MSG'
((type *)0)->member) && \
expansion of macro '__same_type'
((type *)0)->member) && \
y/debugfs.c:224:10: note: in expansion of macro 'container_of'

invalid type argument of unary '*' (have 'int')
in definition of macro '__compiletime_assert'
in expansion of macro '_compiletime_assert'
__compiletime_assert_, __LINE__)
in expansion of macro 'compiletime_assert'
e_assert(!(cond), msg)
~~~~~~~~
expansion of macro 'BUILD_BUG_ON_MSG'
((type *)0)->member) && \
expansion of macro '__same_type'
y/debugfs.c:224:10: note: in expansion of macro 'container_of'

r> 7,
dcom/b43legacy/debugfs.c:26:
In function 'b43legacy_debugfs_write':
cast to pointer from integer of different size [-Wint-to-pointer-cast]
note: in expansion of macro 'container_of'

:0,
dcom/b43legacy/debugfs.c:26:
invalid type argument of unary '*' (have 'int')
((type *)0)->member) && \
in definition of macro '__compiletime_assert'
in expansion of macro '_compiletime_assert'
__compiletime_assert_, __LINE__)
in expansion of macro 'compiletime_assert'
e_assert(!(cond), msg)
~~~~~~~~
expansion of macro 'BUILD_BUG_ON_MSG'
((type *)0)->member) && \
expansion of macro '__same_type'
((type *)0)->member) && \
note: in expansion of macro 'container_of'

invalid type argument of unary '*' (have 'int')
in definition of macro '__compiletime_assert'
in expansion of macro '_compiletime_assert'
__compiletime_assert_, __LINE__)
in expansion of macro 'compiletime_assert'
e_assert(!(cond), msg)
~~~~~~~~
expansion of macro 'BUILD_BUG_ON_MSG'
((type *)0)->member) && \
expansion of macro '__same_type'
note: in expansion of macro 'container_of'

broadcom/b43legacy/debugfs.c
Larry Finger 2007-09-25 25
Larry Finger 2007-09-25 @26 #include <linux/fs.h>
Larry Finger 2007-09-25 27 #include <linux/debugfs.h>
Larry Finger 2007-09-25 28 #include <linux/slab.h>
Larry Finger 2007-09-25 29 #include <linux/netdevice.h>
Larry Finger 2007-09-25 30 #include <linux/pci.h>
Larry Finger 2007-09-25 31 #include <linux/mutex.h>
Larry Finger 2007-09-25 32
Larry Finger 2007-09-25 33 #include "b43legacy.h"
Larry Finger 2007-09-25 34 #include "main.h"
Larry Finger 2007-09-25 35 #include "debugfs.h"
Larry Finger 2007-09-25 36 #include "dma.h"
Larry Finger 2007-09-25 37 #include "pio.h"
Larry Finger 2007-09-25 38 #include "xmit.h"
Larry Finger 2007-09-25 39
Larry Finger 2007-09-25 40
Larry Finger 2007-09-25 41 /* The root directory. */
Larry Finger 2007-09-25 42 static struct dentry *rootdir;
Larry Finger 2007-09-25 43
Larry Finger 2007-09-25 44 struct b43legacy_debugfs_fops {
Larry Finger 2007-09-25 45 ssize_t (*read)(struct b43legacy_wldev *dev, char *buf, size_t bufsize);
Larry Finger 2007-09-25 46 int (*write)(struct b43legacy_wldev *dev, const char *buf, size_t count);
Larry Finger 2007-09-25 47 struct file_operations fops;
Larry Finger 2007-09-25 48 /* Offset of struct b43legacy_dfs_file in struct b43legacy_dfsentry */
Larry Finger 2007-09-25 49 size_t file_struct_offset;
Larry Finger 2007-09-25 50 /* Take wl->irq_lock before calling read/write? */
Larry Finger 2007-09-25 51 bool take_irqlock;
Larry Finger 2007-09-25 52 };
Larry Finger 2007-09-25 53
Larry Finger 2007-09-25 54 static inline
Larry Finger 2007-09-25 55 struct b43legacy_dfs_file * fops_to_dfs_file(struct b43legacy_wldev *dev,
Larry Finger 2007-09-25 56 const struct b43legacy_debugfs_fops *dfops)
Larry Finger 2007-09-25 57 {
Larry Finger 2007-09-25 58 void *p;
Larry Finger 2007-09-25 59
Larry Finger 2007-09-25 60 p = dev->dfsentry;
Larry Finger 2007-09-25 61 p += dfops->file_struct_offset;
Larry Finger 2007-09-25 62
Larry Finger 2007-09-25 63 return p;
Larry Finger 2007-09-25 64 }
Larry Finger 2007-09-25 65
Larry Finger 2007-09-25 66
Larry Finger 2007-09-25 67 #define fappend(fmt, x...) \
Larry Finger 2007-09-25 68 do { \
Larry Finger 2007-09-25 69 if (bufsize - count) \
Larry Finger 2007-09-25 70 count += snprintf(buf + count, \
Larry Finger 2007-09-25 71 bufsize - count, \
Larry Finger 2007-09-25 72 fmt , ##x); \
Larry Finger 2007-09-25 73 else \
Larry Finger 2007-09-25 74 printk(KERN_ERR "b43legacy: fappend overflow\n"); \
Larry Finger 2007-09-25 75 } while (0)
Larry Finger 2007-09-25 76
Larry Finger 2007-09-25 77
Larry Finger 2007-09-25 78 /* wl->irq_lock is locked */
Larry Finger 2007-09-25 79 static ssize_t tsf_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize)
Larry Finger 2007-09-25 80 {
Larry Finger 2007-09-25 81 ssize_t count = 0;
Larry Finger 2007-09-25 82 u64 tsf;
Larry Finger 2007-09-25 83
Larry Finger 2007-09-25 84 b43legacy_tsf_read(dev, &tsf);
Larry Finger 2007-09-25 85 fappend("0x%08x%08x\n",
Larry Finger 2007-09-25 86 (unsigned int)((tsf & 0xFFFFFFFF00000000ULL) >> 32),
Larry Finger 2007-09-25 87 (unsigned int)(tsf & 0xFFFFFFFFULL));
Larry Finger 2007-09-25 88
Larry Finger 2007-09-25 89 return count;
Larry Finger 2007-09-25 90 }
Larry Finger 2007-09-25 91
Larry Finger 2007-09-25 92 /* wl->irq_lock is locked */
Larry Finger 2007-09-25 93 static int tsf_write_file(struct b43legacy_wldev *dev, const char *buf, size_t count)
Larry Finger 2007-09-25 94 {
Larry Finger 2007-09-25 95 u64 tsf;
Larry Finger 2007-09-25 96
Larry Finger 2007-09-25 97 if (sscanf(buf, "%llu", (unsigned long long *)(&tsf)) != 1)
Larry Finger 2007-09-25 98 return -EINVAL;
Larry Finger 2007-09-25 99 b43legacy_tsf_write(dev, tsf);
Larry Finger 2007-09-25 100
Larry Finger 2007-09-25 101 return 0;
Larry Finger 2007-09-25 102 }
Larry Finger 2007-09-25 103
Larry Finger 2007-09-25 104 /* wl->irq_lock is locked */
Larry Finger 2007-09-25 105 static ssize_t ucode_regs_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize)
Larry Finger 2007-09-25 106 {
Larry Finger 2007-09-25 107 ssize_t count = 0;
Larry Finger 2007-09-25 108 int i;
Larry Finger 2007-09-25 109
Larry Finger 2007-09-25 110 for (i = 0; i < 64; i++) {
Larry Finger 2007-09-25 111 fappend("r%d = 0x%04x\n", i,
Larry Finger 2007-09-25 112 b43legacy_shm_read16(dev, B43legacy_SHM_WIRELESS, i));
Larry Finger 2007-09-25 113 }
Larry Finger 2007-09-25 114
Larry Finger 2007-09-25 115 return count;
Larry Finger 2007-09-25 116 }
Larry Finger 2007-09-25 117
Larry Finger 2007-09-25 118 /* wl->irq_lock is locked */
Larry Finger 2007-09-25 119 static ssize_t shm_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize)
Larry Finger 2007-09-25 120 {
Larry Finger 2007-09-25 121 ssize_t count = 0;
Larry Finger 2007-09-25 122 int i;
Larry Finger 2007-09-25 123 u16 tmp;
Larry Finger 2007-09-25 124 __le16 *le16buf = (__le16 *)buf;
Larry Finger 2007-09-25 125
Larry Finger 2007-09-25 126 for (i = 0; i < 0x1000; i++) {
Stefano Brivio 2007-11-06 127 if (bufsize < sizeof(tmp))
Larry Finger 2007-09-25 128 break;
Larry Finger 2007-09-25 129 tmp = b43legacy_shm_read16(dev, B43legacy_SHM_SHARED, 2 * i);
Larry Finger 2007-09-25 130 le16buf[i] = cpu_to_le16(tmp);
Larry Finger 2007-09-25 131 count += sizeof(tmp);
Larry Finger 2007-09-25 132 bufsize -= sizeof(tmp);
Larry Finger 2007-09-25 133 }
Larry Finger 2007-09-25 134
Larry Finger 2007-09-25 135 return count;
Larry Finger 2007-09-25 136 }
Larry Finger 2007-09-25 137
Larry Finger 2007-09-25 138 static ssize_t txstat_read_file(struct b43legacy_wldev *dev, char *buf, size_t bufsize)
Larry Finger 2007-09-25 139 {
Larry Finger 2007-09-25 140 struct b43legacy_txstatus_log *log = &dev->dfsentry->txstatlog;
Larry Finger 2007-09-25 141 ssize_t count = 0;
Larry Finger 2007-09-25 142 unsigned long flags;
Larry Finger 2007-09-25 143 int i, idx;
Larry Finger 2007-09-25 144 struct b43legacy_txstatus *stat;
Larry Finger 2007-09-25 145
Larry Finger 2007-09-25 146 spin_lock_irqsave(&log->lock, flags);
Larry Finger 2007-09-25 147 if (log->end < 0) {
Larry Finger 2007-09-25 148 fappend("Nothing transmitted, yet\n");
Larry Finger 2007-09-25 149 goto out_unlock;
Larry Finger 2007-09-25 150 }
Larry Finger 2007-09-25 151 fappend("b43legacy TX status reports:\n\n"
Larry Finger 2007-09-25 152 "index | cookie | seq | phy_stat | frame_count | "
Larry Finger 2007-09-25 153 "rts_count | supp_reason | pm_indicated | "
Larry Finger 2007-09-25 154 "intermediate | for_ampdu | acked\n" "---\n");
Larry Finger 2007-09-25 155 i = log->end + 1;
Larry Finger 2007-09-25 156 idx = 0;
Larry Finger 2007-09-25 157 while (1) {
Larry Finger 2007-09-25 158 if (i == B43legacy_NR_LOGGED_TXSTATUS)
Larry Finger 2007-09-25 159 i = 0;
Larry Finger 2007-09-25 160 stat = &(log->log[i]);
Larry Finger 2007-09-25 161 if (stat->cookie) {
Larry Finger 2007-09-25 162 fappend("%03d | "
Larry Finger 2007-09-25 163 "0x%04X | 0x%04X | 0x%02X | "
Larry Finger 2007-09-25 164 "0x%X | 0x%X | "
Larry Finger 2007-09-25 165 "%u | %u | "
Larry Finger 2007-09-25 166 "%u | %u | %u\n",
Larry Finger 2007-09-25 167 idx,
Larry Finger 2007-09-25 168 stat->cookie, stat->seq, stat->phy_stat,
Larry Finger 2007-09-25 169 stat->frame_count, stat->rts_count,
Larry Finger 2007-09-25 170 stat->supp_reason, stat->pm_indicated,
Larry Finger 2007-09-25 171 stat->intermediate, stat->for_ampdu,
Larry Finger 2007-09-25 172 stat->acked);
Larry Finger 2007-09-25 173 idx++;
Larry Finger 2007-09-25 174 }
Larry Finger 2007-09-25 175 if (i == log->end)
Larry Finger 2007-09-25 176 break;
Larry Finger 2007-09-25 177 i++;
Larry Finger 2007-09-25 178 }
Larry Finger 2007-09-25 179 out_unlock:
Larry Finger 2007-09-25 180 spin_unlock_irqrestore(&log->lock, flags);
Larry Finger 2007-09-25 181
Larry Finger 2007-09-25 182 return count;
Larry Finger 2007-09-25 183 }
Larry Finger 2007-09-25 184
Larry Finger 2007-09-25 185 /* wl->irq_lock is locked */
Larry Finger 2007-09-25 186 static int restart_write_file(struct b43legacy_wldev *dev, const char *buf, size_t count)
Larry Finger 2007-09-25 187 {
Larry Finger 2007-09-25 188 int err = 0;
Larry Finger 2007-09-25 189
Larry Finger 2007-09-25 190 if (count > 0 && buf[0] == '1') {
Larry Finger 2007-09-25 191 b43legacy_controller_restart(dev, "manually restarted");
Larry Finger 2007-09-25 192 } else
Larry Finger 2007-09-25 193 err = -EINVAL;
Larry Finger 2007-09-25 194
Larry Finger 2007-09-25 195 return err;
Larry Finger 2007-09-25 196 }
Larry Finger 2007-09-25 197
Larry Finger 2007-09-25 198 #undef fappend
Larry Finger 2007-09-25 199
Larry Finger 2007-09-25 200 static ssize_t b43legacy_debugfs_read(struct file *file, char __user *userbuf,
Larry Finger 2007-09-25 201 size_t count, loff_t *ppos)
Larry Finger 2007-09-25 202 {
Larry Finger 2007-09-25 203 struct b43legacy_wldev *dev;
Larry Finger 2007-09-25 204 struct b43legacy_debugfs_fops *dfops;
Larry Finger 2007-09-25 205 struct b43legacy_dfs_file *dfile;
Frank Lichtenheld 2007-11-24 206 ssize_t uninitialized_var(ret);
Larry Finger 2007-09-25 207 char *buf;
Larry Finger 2008-12-09 208 const size_t bufsize = 1024 * 16; /* 16 KiB buffer */
Larry Finger 2007-09-25 209 const size_t buforder = get_order(bufsize);
Larry Finger 2007-09-25 210 int err = 0;
Larry Finger 2007-09-25 211
Larry Finger 2007-09-25 212 if (!count)
Larry Finger 2007-09-25 213 return 0;
Larry Finger 2007-09-25 214 dev = file->private_data;
Larry Finger 2007-09-25 215 if (!dev)
Larry Finger 2007-09-25 216 return -ENODEV;
Larry Finger 2007-09-25 217
Larry Finger 2007-09-25 218 mutex_lock(&dev->wl->mutex);
Larry Finger 2007-09-25 219 if (b43legacy_status(dev) < B43legacy_STAT_INITIALIZED) {
Larry Finger 2007-09-25 220 err = -ENODEV;
Larry Finger 2007-09-25 221 goto out_unlock;
Larry Finger 2007-09-25 222 }
Larry Finger 2007-09-25 223
Christian Lamparter 2016-09-17 @224 dfops = container_of(debugfs_real_fops(file),
Christian Lamparter 2016-09-17 225 struct b43legacy_debugfs_fops, fops);
Larry Finger 2007-09-25 226 if (!dfops->read) {
Larry Finger 2007-09-25 227 err = -ENOSYS;
Larry Finger 2007-09-25 228 goto out_unlock;
Larry Finger 2007-09-25 229 }
Larry Finger 2007-09-25 230 dfile = fops_to_dfs_file(dev, dfops);
Larry Finger 2007-09-25 231
Larry Finger 2007-09-25 232 if (!dfile->buffer) {
Larry Finger 2007-09-25 233 buf = (char *)__get_free_pages(GFP_KERNEL, buforder);
Larry Finger 2007-09-25 234 if (!buf) {
Larry Finger 2007-09-25 235 err = -ENOMEM;
Larry Finger 2007-09-25 236 goto out_unlock;
Larry Finger 2007-09-25 237 }
Larry Finger 2007-09-25 238 memset(buf, 0, bufsize);
Larry Finger 2007-09-25 239 if (dfops->take_irqlock) {
Larry Finger 2007-09-25 240 spin_lock_irq(&dev->wl->irq_lock);
Larry Finger 2007-09-25 241 ret = dfops->read(dev, buf, bufsize);
Larry Finger 2007-09-25 242 spin_unlock_irq(&dev->wl->irq_lock);
Larry Finger 2007-09-25 243 } else
Larry Finger 2007-09-25 244 ret = dfops->read(dev, buf, bufsize);
Larry Finger 2007-09-25 245 if (ret <= 0) {
Larry Finger 2007-09-25 246 free_pages((unsigned long)buf, buforder);
Larry Finger 2007-09-25 247 err = ret;
Larry Finger 2007-09-25 248 goto out_unlock;
Larry Finger 2007-09-25 249 }
Larry Finger 2007-09-25 250 dfile->data_len = ret;
Larry Finger 2007-09-25 251 dfile->buffer = buf;
Larry Finger 2007-09-25 252 }
Larry Finger 2007-09-25 253
Larry Finger 2007-09-25 254 ret = simple_read_from_buffer(userbuf, count, ppos,
Larry Finger 2007-09-25 255 dfile->buffer,
Larry Finger 2007-09-25 256 dfile->data_len);
Larry Finger 2007-09-25 257 if (*ppos >= dfile->data_len) {
Larry Finger 2007-09-25 258 free_pages((unsigned long)dfile->buffer, buforder);
Larry Finger 2007-09-25 259 dfile->buffer = NULL;
Larry Finger 2007-09-25 260 dfile->data_len = 0;
Larry Finger 2007-09-25 261 }
Larry Finger 2007-09-25 262 out_unlock:
Larry Finger 2007-09-25 263 mutex_unlock(&dev->wl->mutex);
Larry Finger 2007-09-25 264
Larry Finger 2007-09-25 265 return err ? err : ret;
Larry Finger 2007-09-25 266 }
Larry Finger 2007-09-25 267
by commit
b43legacy: fix debugfs crash
xxxxxxxx>
xxxxxxxxxx>
Open Source Technology Center
rmail/kbuild-all">https://lists.01.org/pipermail/kbuild-all Intel Corporation
>

Next message: Miles Chen: "Re: [PATCH v4] dma-debug: fix incorrect pfn calculation"
Previous message: Yunlong Song: "[PATCH v3 RESEND] f2fs: add bug_on when f2fs_gc even fails to get one victim"
Next in thread: Greg Kroah-Hartman: "Re: drivers/net/wireless/broadcom/b43legacy/debugfs.c:224:23: error: implicit declaration of function 'debugfs_real_fops'"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]