Re: [PATCH v7 02/13] dt-bindings: Add SLIMbus bindings

[Vinod Koul]

On Thu, Nov 16, 2017 at 01:40:13PM +0000, Srinivas Kandagatla wrote:
> Thanks for the review comments.
> 
> On 16/11/17 13:09, Vinod Koul wrote:
> >On Wed, Nov 15, 2017 at 02:10:32PM +0000, srinivas.kandagatla@xxxxxxxxxx wrote:
> >>From: Sagar Dharia <sdharia@xxxxxxxxxxxxxx>
> >
> >>+
> >>+Child nodes:
> >>+Every SLIMbus controller node can contain zero or more child nodes
> >>+representing slave devices on the bus. Every SLIMbus slave device is
> >>+uniquely determined by the enumeration address containing 4 fields:
> >>+Manufacturer ID, Product code, Device index, and Instance value for
> >>+the device.
> >>+If child node is not present and it is instantiated after device
> >>+discovery (slave device reporting itself present).
> >
> >So you allow the devices to work even if the respective firmware description
> >is absent?
> Yes, As SLIMbus itself itself is discoverable bus.

Okay, in SDW we mandate description be present in respective firmwares so we
dont have this path. In theory this never works for you as driver cant load
without device being created and without driver load device is not powered
up so can't report...

> >>+In some cases it may be necessary to describe non-probeable device
> >>+details such as non-standard ways of powering up a device. In
> >>+such cases, child nodes for those devices will be present as
> >>+slaves of the slimbus-controller, as detailed below.
> >>+
> >>+Required property for SLIMbus child node if it is present:
> >>+- reg		- Should be ('Device index', 'Instance ID') from SLIMbus
> >>+		  Enumeration  Address.
> >>+		  Device Index Uniquely identifies multiple Devices within
> >>+		  a single Component.
> >>+		  Instance ID Is for the cases where multiple Devices of the
> >>+		  same type or Class are attached to the bus.
> >>+
> >>+- compatible	-"slimMID,PID". The textual representation of Manufacturer ID,
> >>+	 	  Product Code, shall be in lower case hexadecimal with leading
> >>+		  zeroes suppressed
> >>+
> 
> >>+		codec: wcd9310@1,0{
> >>+			compatible = "slim217,60";
> >>+			reg = <1 0>;
> >>+		};
> >>+	};
> >
> >Pardon my ignorance as I am not very familiar with DT nodes, but where are
> >the Manufacturer ID, Product code, Device index, and Instance values here?
> 
> Manfacturer ID and Product code is part of compatible string
> Device index and Instance value are part of reg.

hmmm, wouldn't it be more helpful to have a field(s) for these which contain
these numbers rather than coded together in a word

compatible makes sense though

-- 
~Vinod