Re: [PATCH V1 1/4] qcom: spmi-wled: Add support for qcom wled driver

From: kgunda
Date: Fri Nov 17 2017 - 01:36:22 EST

On 2017-11-16 22:25, Bjorn Andersson wrote:
On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote:

WLED driver provides the interface to the display driver to
adjust the brightness of the display backlight.

Hi Kiran,

This driver has a lot in common with the already upstream pm8941-wled.c,
because it's just a new revision of the same block.

Please extend the existing driver rather than providing a new one
(and yes, renaming the file is okay).


Hi Bjorn,

Yes this driver design is similar to pm8941, however the WLED HW block has undergone quite a few changes in
analog and digital from PM8941 to PM8998. Few of them include splitting one module into wled-ctrl
and wled-sink peripherals, changes in the register offsets and the bit interpretation. Hence we
concluded that it was better to have a new driver to support this new gen WELD module and decouple
it from the pm8941. Also, going forward this driver will support AMOLED AVDD rail (not supported by pm8941)
touching a few more registers/configuration and newer PMICs. So spinning off a new driver would make it
cleaner and easier to extend further.


To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at