Re: [PATCH] gpu: gma500: remove unneeded DRIVER_LICENSE #define

From: Philippe Ombredanne
Date: Fri Nov 17 2017 - 09:51:30 EST


On Fri, Nov 17, 2017 at 3:16 PM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference, especially when the string is defined in a .h file
> far away from the .c file it is used in.
>
> Cc: Patrik Jakobsson <patrik.r.jakobsson@xxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Reported-by: Philippe Ombredanne <pombredanne@xxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Reviewed-by: Philippe Ombredanne <pombredanne@xxxxxxxx>

--
Cordially
Philippe Ombredanne