Re: [PATCH] iommu/vt-d: Fix scatterlist offset handling
From: Raj, Ashok
Date: Fri Nov 17 2017 - 11:26:30 EST
Hi Alex
On Fri, Nov 17, 2017 at 09:18:14AM -0700, Alex Williamson wrote:
> On Thu, 16 Nov 2017 13:09:33 -0800
> "Raj, Ashok" <ashok.raj@xxxxxxxxx> wrote:
>
> > >
> > > What do we do about this? I certainly can't rip out large page support
> > > and put a stable tag on the patch. I'm not really spotting what's
> > > wrong with large page support here, other than the comment about it
> > > being a mess. Suggestions? Thanks,
> > >
> >
> > Largepage seems to work and i don't think we need to rip it out. When
> > Harsh tested it at one point we thought disabling super-page seemed to make
> > the problem go away. Jacob tested and we still saw the need for Robin's patch.
> >
> > Yes, the function looks humongous but i don't think we should wait for that
> > before this merge.
>
> Ok. Who wants to toss in review and testing sign-offs? Clearly
> there's been a lot more eyes and effort on this patch than reflected in
> the original posting. I'll add a stable cc. Thanks,
Reported by: Harsh <harsh@xxxxxxxxxxx>
Reviewed by: Ashok Raj <ashok.raj@xxxxxxxxx>
Tested by: Jacob Pan <jacob.jun.pan@xxxxxxxxx>
>
> Alex