Re: [PATCH V6] clk: qcom: Add spmi_pmic clock divider support

From: Rob Herring
Date: Fri Nov 17 2017 - 15:23:17 EST


On Fri, Nov 17, 2017 at 03:18:47PM +0530, Tirupathi Reddy wrote:
> Clkdiv module provides a clock output on the PMIC with CXO as
> the source. This clock can be routed through PMIC GPIOs. Add
> a device driver to configure this clkdiv module.
>
> Signed-off-by: Tirupathi Reddy <tirupath@xxxxxxxxxxxxxx>
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxxxxxx>

Normally your S-o-B would be last.

> ---
> .../bindings/clock/clk-spmi-pmic-div.txt | 59 ++++

Please split bindings to a separate patch.

Otherwise,

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> drivers/clk/qcom/Kconfig | 9 +
> drivers/clk/qcom/Makefile | 1 +
> drivers/clk/qcom/clk-spmi-pmic-div.c | 308 +++++++++++++++++++++
> 4 files changed, 377 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/clk-spmi-pmic-div.txt
> create mode 100644 drivers/clk/qcom/clk-spmi-pmic-div.c