Re: [PATCH 04/10] Input: serio: Fix platform_get_irq's error checking

[Dmitry Torokhov]

On Sat, Nov 18, 2017 at 12:45:26AM +0530, Arvind Yadav wrote:
> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
> ---
>  drivers/input/serio/sun4i-ps2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/serio/sun4i-ps2.c b/drivers/input/serio/sun4i-ps2.c
> index 04b96fe..405c82f 100644
> --- a/drivers/input/serio/sun4i-ps2.c
> +++ b/drivers/input/serio/sun4i-ps2.c
> @@ -264,7 +264,7 @@ static int sun4i_ps2_probe(struct platform_device *pdev)
>  
>  	/* Get IRQ for the device */
>  	irq = platform_get_irq(pdev, 0);
> -	if (!irq) {
> +	if (irq < 0) {

irq is unsigned.

>  		dev_err(dev, "no IRQ found\n");
>  		error = -ENXIO;

I'd rather we did not clobber error.

>  		goto err_disable_clk;
> -- 
> 2.7.4
> 

-- 
Dmitry