Re: [PATCH] input: remove unneeded DRIVER_LICENSE #defines

From: Greg Kroah-Hartman
Date: Sat Nov 18 2017 - 07:50:16 EST


On Sat, Nov 18, 2017 at 01:39:03PM +0100, Philippe Ombredanne wrote:
> On Sat, Nov 18, 2017 at 11:27 AM, Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > Please do, I got rid of all of the DRIVER_VERSION crap in the
> > drivers/usb/ tree a release or so ago, as they make no sense at all.
> > The other defines are also really silly and can be cleaned up too.
> >
> > Want me to do that for drivers/input/ for you?
> >
> > thanks,
> >
> > greg "I'm a janitor now" k-h
>
>
> Thing could get worse: you could become a documentalist like tglx turned into.
>
> For the fun, another weird thingie that I once stumbled upon in an
> out-of-tree third-party module:
>
> MODULE_LICENSE("\x47\x50\x4c\x20\x76\x32");
>
> ... which was most likely from a GPL-shy closet Free software
> advocate: this is "GPL v2" in ASCII.

Hah, we've seen worse with people trying to put '0x00' in the middle of
the string to fake out the string checking logic. Whenever stuff like
that gets pointed out to the legal department of the company involved,
stuff gets fixed fast, trying to 'circumvent' a license check is really
frowned apon by almost all legal juristictions :)

So, if you want to point that code out to me offline, I'm sure I could
have some fun...

thanks,

greg k-h