Re: [PATCH v2] iio: core: Mark expected switch fall-through

From: Jonathan Cameron
Date: Sun Nov 19 2017 - 09:48:59 EST


On Wed, 8 Nov 2017 12:08:26 -0600
"Gustavo A. R. Silva" <garsilva@xxxxxxxxxxxxxx> wrote:

> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Addresses-Coverity-ID: 1397962
> Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
Applied to the togreg branch of iio.git and will be pushed out as
testing.

Thanks,

Jonathan
> ---
> Changes in v2:
> Fix subject line.
>
> drivers/iio/industrialio-core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
> index 9c4cfd1..2e8e36f 100644
> --- a/drivers/iio/industrialio-core.c
> +++ b/drivers/iio/industrialio-core.c
> @@ -588,6 +588,7 @@ static ssize_t __iio_format_value(char *buf, size_t len, unsigned int type,
> return snprintf(buf, len, "%d", vals[0]);
> case IIO_VAL_INT_PLUS_MICRO_DB:
> scale_db = true;
> + /* fall through */
> case IIO_VAL_INT_PLUS_MICRO:
> if (vals[1] < 0)
> return snprintf(buf, len, "-%d.%06u%s", abs(vals[0]),