Re: [PATCH] Staging: comedi: adl_pci9118.c : fixed code style issue

[Ian Abbott]

On 18/11/17 17:46, Fabian Baumanis wrote:
> Removed uneccessary parantheses which were sorrounding two
> if-statements.

There is only one 'if' statement changed by the patch.  Apart from that 
(and the typos in the patch description), the patch is fine as far as it 
goes.  However, the checkpatch script identifies several similar 
"unnecessary parentheses" issues in this file, and it would be better to 
take care of them all with a single patch rather than patching them one 
at a time.

> Signed-off-by: Fabian Baumanis <baumanisf@xxxxxxxxx>
> ---
>  Âdrivers/staging/comedi/drivers/adl_pci9118.c | 3 +--
>  Â1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c
> index 1cc9b7e..c77b994 100644
> --- a/drivers/staging/comedi/drivers/adl_pci9118.c
> +++ b/drivers/staging/comedi/drivers/adl_pci9118.c
> @@ -946,8 +946,7 @@ static int pci9118_ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
>  ÂÂÂÂÂÂÂ devpriv->ai_add_back = 0;
>  ÂÂÂÂÂÂÂ if (devpriv->master) {
>  ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ devpriv->usedma = 1;
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ if ((cmd->flags & CMDF_WAKE_EOS) &&
> -ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ (cmd->scan_end_arg == 1)) {
> +ÂÂÂÂÂÂÂÂÂÂÂÂÂÂ if (cmd->flags & CMDF_WAKE_EOS && cmd->scan_end_arg == 1) {
>  ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ if (cmd->convert_src == TRIG_NOW)
>  ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ devpriv->ai_add_back = 1;
>  ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ if (cmd->convert_src == TRIG_TIMER) {


--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-