Re: [PATCH V2 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support

From: Peter Zijlstra
Date: Mon Nov 20 2017 - 06:57:31 EST


On Fri, Nov 17, 2017 at 05:54:05PM -0800, Megha Dey wrote:
> + mutex_lock(&bm_counter_mutex);
> + for (i = 0; i < BM_MAX_COUNTERS; i++) {
> + if (bm_counter_owner[i] == NULL) {
> + counter_to_use = i;
> + bm_counter_owner[i] = event;
> + break;
> + }
> + }
> + mutex_unlock(&bm_counter_mutex);
> +
> + if (counter_to_use == -1)
> + return -EBUSY;

> +static struct pmu intel_bm_pmu = {
> + .task_ctx_nr = perf_sw_context,
> + .attr_groups = intel_bm_attr_groups,
> + .event_init = intel_bm_event_init,
> + .add = intel_bm_event_add,
> + .del = intel_bm_event_del,
> +};

Still horrid.. still no.