Re: [PATCH v2 3/3] net: ethernet: fec: fix refclk enable for SMSC LAN8710/20

From: Geert Uytterhoeven
Date: Mon Nov 20 2017 - 08:40:22 EST

Hi Richard,

On Mon, Nov 20, 2017 at 2:21 PM, Richard Leitner
<richard.leitner@xxxxxxxxxxx> wrote:
> On 11/20/2017 02:13 PM, Geert Uytterhoeven wrote:
>> On Mon, Nov 20, 2017 at 1:55 PM, Richard Leitner
>> <richard.leitner@xxxxxxxxxxx> wrote:
>>> On 11/20/2017 11:35 AM, Andy Duan wrote:
>>>> 3. add reset gpio descriptor for common phy device driver.
>>> ... if I understood it correctly the patch called "Teach phylib
>>> hard-resetting devices" by Geert and Sergei is exactly doing this:
>>> So I'll implement the phy_reset_after_clk_enable function atop of this
>>> patch-set and add a note that my patch-series depends on it. Would that
>>> be OK?
>> I will update and respin that patch series after the merge window has closed.
> Ok. Thank you for the quick response an this information.
> For the Freescale Fast Ethernet Controller (FEC) there are currently (in
> addition to the reset gpio) two additional optional dt properties for
> the reset:
> - phy-reset-duration : Reset duration in milliseconds.
> - phy-reset-post-delay : Post reset delay in milliseconds.
> IMHO it would make sense to include them also in the phylib
> implementation. What do you think about it? Should I include it in my
> patch-series?

Sure, you can always extend phylib, building on top of our simple reset

BTW, I think phy-reset-{duration,post-delay} should be moved to the
phy node as well, dropping the "phy-" prefix in the process.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds