Re: [PATCH v3 1/3] leds: core: Introduce generic pattern interface

From: Pavel Machek
Date: Mon Nov 20 2017 - 18:20:23 EST

On Wed 2017-11-15 08:36:42, Greg KH wrote:
> On Tue, Nov 14, 2017 at 11:13:43PM -0800, Bjorn Andersson wrote:
> > Some LED controllers have support for autonomously controlling
> > brightness over time, according to some preprogrammed pattern or
> > function.
> >
> > This adds a new optional operator that LED class drivers can implement
> > if they support such functionality as well as a new device attribute to
> > configure the pattern for a given LED.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> > ---
> >
> > Changes since v2:
> > - None
> >
> > Changes since v1:
> > - New patch, based on discussions following v1
> >
> > Documentation/ABI/testing/sysfs-class-led | 20 ++++
> > drivers/leds/led-class.c | 150 ++++++++++++++++++++++++++++++
> > include/linux/leds.h | 21 +++++
> > 3 files changed, 191 insertions(+)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-class-led b/Documentation/ABI/testing/sysfs-class-led
> > index 5f67f7ab277b..74a7f5b1f89b 100644
> > --- a/Documentation/ABI/testing/sysfs-class-led
> > +++ b/Documentation/ABI/testing/sysfs-class-led
> > @@ -61,3 +61,23 @@ Description:
> > gpio and backlight triggers. In case of the backlight trigger,
> > it is useful when driving a LED which is intended to indicate
> > a device in a standby like state.
> > +
> > +What: /sys/class/leds/<led>/pattern
> > +Date: July 2017
>
> That was many months ago :)
>
> > +KernelVersion: 4.14
>
> And that kernel version is long since released :)

Yeah, the other problem is it has some interesting format with ":|"
marking repeat, and is not really suitable for RGB LEDs...

I'd really prefer to get driver in first, and add pattern interface
later.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature