Re: [PATCH v15 5/5] PCI: Remove PCI pool macro functions

From: Romain Perier
Date: Tue Nov 21 2017 - 03:39:12 EST


Whoops, my bad. Sorry

Thanks,
Romain

2017-11-20 21:34 GMT+01:00 Bjorn Helgaas <helgaas@xxxxxxxxxx>:
> On Mon, Nov 20, 2017 at 08:32:47PM +0100, Romain Perier wrote:
>> From: Romain Perier <romain.perier@xxxxxxxxxxxxx>
>>
>> Now that all the drivers use dma pool API, we can remove the macro
>> functions for PCI pool.
>>
>> Signed-off-by: Romain Perier <romain.perier@xxxxxxxxxxxxx>
>> Reviewed-by: Peter Senna Tschudin <peter.senna@xxxxxxxxxxxxx>
>
> I already acked this once on Oct 24. Please keep that ack and include
> it in any future postings so I don't have to deal with this again.
>
> Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>
>> ---
>> include/linux/pci.h | 9 ---------
>> 1 file changed, 9 deletions(-)
>>
>> diff --git a/include/linux/pci.h b/include/linux/pci.h
>> index 96c94980d1ff..d03b4a20033d 100644
>> --- a/include/linux/pci.h
>> +++ b/include/linux/pci.h
>> @@ -1324,15 +1324,6 @@ int pci_set_vga_state(struct pci_dev *pdev, bool decode,
>> #include <linux/pci-dma.h>
>> #include <linux/dmapool.h>
>>
>> -#define pci_pool dma_pool
>> -#define pci_pool_create(name, pdev, size, align, allocation) \
>> - dma_pool_create(name, &pdev->dev, size, align, allocation)
>> -#define pci_pool_destroy(pool) dma_pool_destroy(pool)
>> -#define pci_pool_alloc(pool, flags, handle) dma_pool_alloc(pool, flags, handle)
>> -#define pci_pool_zalloc(pool, flags, handle) \
>> - dma_pool_zalloc(pool, flags, handle)
>> -#define pci_pool_free(pool, vaddr, addr) dma_pool_free(pool, vaddr, addr)
>> -
>> struct msix_entry {
>> u32 vector; /* kernel uses to write allocated vector */
>> u16 entry; /* driver uses to specify entry, OS writes */
>> --
>> 2.14.1
>>