Re: [PATCH v1 8/9] perf stat: Remove --per-thread pid/tid limitation

From: Jiri Olsa
Date: Tue Nov 21 2017 - 10:18:21 EST


On Mon, Nov 20, 2017 at 10:43:43PM +0800, Jin Yao wrote:

SNIP

> - if ((stat_config.aggr_mode == AGGR_THREAD) && !target__has_task(&target)) {
> - fprintf(stderr, "The --per-thread option is only available "
> - "when monitoring via -p -t options.\n");
> - parse_options_usage(NULL, stat_options, "p", 1);
> - parse_options_usage(NULL, stat_options, "t", 1);
> - goto out;
> + if ((stat_config.aggr_mode == AGGR_THREAD) &&
> + !target__has_task(&target)) {
> + if (!target.system_wide || target.cpu_list) {
> + fprintf(stderr, "The --per-thread option is only "
> + "available when monitoring via -p -t "
> + "options.\n");

the message should be updated with '-a' option, that you just added,
also why dont we support target.cpu_list, it should work no?

jirka