Re: [PATCH 4.14 00/31] 4.14.1-stable review

From: Greg Kroah-Hartman
Date: Tue Nov 21 2017 - 12:09:18 EST


On Tue, Nov 21, 2017 at 04:46:18PM +0000, Ben Hutchings wrote:
> On Tue, 2017-11-21 at 17:35 +0100, Greg Kroah-Hartman wrote:
> > On Tue, Nov 21, 2017 at 03:26:10PM +0000, Ben Hutchings wrote:
> [...]
> > > Not all 32-bit configurations can provide cmpxchg64().  i40e's use of
> > > cmpxchg64() appears to be fixed by:
> > >
> > > b74f571f59a8 i40e/i40evf: organize and re-number feature flags
> > > b48be9978e4b i40e: fix flags declaration
> >
> > So without those patches, are any specific arches/configs broken for
> > 4.14?
>
> 32-bit parisc is.

Ok, but that's a horrid hack on the i40e driver, it just happens to move
the bitfield to a 32bit variable. Can't we just provide a "real"
cmpxchg64() for 32-bit parisc? Or mark this driver as not buildable on
that platform?

I doubt anyone is doing 40gb networking on parisc :)

thanks,

greg k-h