Re: [PATCH] HID: cp2112: Fix I2C_BLOCK_DATA transactions

From: Eudean Sun
Date: Tue Nov 21 2017 - 13:40:22 EST

On Tue, Nov 21, 2017 at 05:45:32PM +0100, Jiri Kosina wrote:
> On Tue, 21 Nov 2017, Jiri Kosina wrote:
> > > The existing driver erroneously treats I2C_BLOCK_DATA and BLOCK_DATA
> > > commands the same. Fix the logic for I2C_BLOCK_DATA reads and writes.
> >
> > Addin David, the original author of the driver (and the code in question
> > as well) to CC.
> Alright, that address bounces.
> In that case -- could you please be a little bit more specific in the
> changelog? Namely: what are the observable effects of this bug (did you
> find it by code inspection or have you seen it triggering) and why this is
> a proper fix for that bug.

Thanks for the feedback Jiri, I will send out a new patch shortly with more detail in the changelog.