kernel_read() changed from v4.13 to v4.14

From: Zytaruk, Kelly
Date: Tue Nov 21 2017 - 16:05:43 EST


I noticed that the parameter ordering to kernel_read() changed from Linux kernel v4.13 to v4.14 when the function was moved into fs/read_write.c from exec.c

4.13.15 - int kernel_read(struct file *file, loff_t offset, char *addr, unsigned long count)

4.14.1 - ssize_t kernel_read(struct file *file, void *buf, size_t count, loff_t *pos)

I am still on the learning curve so I would like to understand why this was done instead of keeping the same ordering.

Notes from the commit message.

commit 581bfce969cbfc7ce43ee92273be9cb7c3fdfa61
.
      fs: make the buf argument to __kernel_write a void pointer
      fs: fix kernel_write prototype
      fs: fix kernel_read prototype
      fs: move kernel_read to fs/read_write.c
      fs: move kernel_write to fs/read_write.c

Thanks,
Kelly