Re: [PATCH v3 RESEND] f2fs: add bug_on when f2fs_gc even fails to get one victim

[Yunlong Song]

ping again...

On 2017/11/17 9:09, Yunlong Song wrote:
> This can help to find potential bugs on some corner case.
>
> Signed-off-by: Yunlong Song <yunlong.song@xxxxxxxxxx>
> ---
>   fs/f2fs/gc.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 5d5bba4..c89128b 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1035,6 +1035,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>   		goto stop;
>   	}
>   	if (!__get_victim(sbi, &segno, gc_type)) {
> +		f2fs_bug_on(sbi, !total_freed && has_not_enough_free_secs(sbi, 0, 0));
>   		ret = -ENODATA;
>   		goto stop;
>   	}

--
Thanks,
Yunlong Song