Re: [PATCH] Staging: sm750fb: sm750: fixed coding style issues

[Joe Perches]

On Wed, 2017-11-22 at 18:33 +0100, Patryk Kocielnik wrote:
> Joe,
> 
> Thank you for your comments!
> 
> I did compile it beforehand and it was clean. Did I miss anything?

You also have to compile it afterhand...

i.e.: with your patch applied

$ make allyesconfig
[]
$ make drivers/staging/sm750fb/
[]
  CC      drivers/staging/sm750fb/sm750.o
drivers/staging/sm750fb/sm750.c: In function âlynxfb_set_fbinfoâ:
drivers/staging/sm750fb/sm750.c:807:19: error: assignment of read-only location âg_fbmode[index]â
   g_fbmode[index] = g_def_fbmode;
                   ^
drivers/staging/sm750fb/sm750.c:809:20: error: assignment of read-only location âg_fbmode[index]â
    g_fbmode[index] = g_fbmode[0];
                    ^
drivers/staging/sm750fb/sm750.c: In function âsm750fb_setupâ:
drivers/staging/sm750fb/sm750.c:978:17: error: assignment of read-only location âg_fbmode[0]â
     g_fbmode[0] = opt;
                 ^
drivers/staging/sm750fb/sm750.c:982:17: error: assignment of read-only location âg_fbmode[1]â
     g_fbmode[1] = opt;
                 ^
scripts/Makefile.build:310: recipe for target 'drivers/staging/sm750fb/sm750.o' failed
make[1]: *** [drivers/staging/sm750fb/sm750.o] Error 1
Makefile:1674: recipe for target 'drivers/staging/sm750fb/' failed
make: *** [drivers/staging/sm750fb/] Error 2

>