Re: [PATCH v2 07/18] x86/asm: Fix assumptions that the HW TSS is at the beginning of cpu_tss

[Borislav Petkov]

On Tue, Nov 21, 2017 at 08:44:02PM -0800, Andy Lutomirski wrote:
> I'm going to move SYSENTER_stack to the beginning of cpu_tss to help
> detect overflow.  Before this can happen, I need to fix several code
> paths that hardcode assumptions about the old layout.

Please formulate that commit message in passive-impersonal: "Fix
hardcoded assumptions about ... before ..."

> 
> Reviewed-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>
> ---
>  arch/x86/include/asm/desc.h      |  2 +-
>  arch/x86/include/asm/processor.h |  4 ++--
>  arch/x86/kernel/cpu/common.c     |  8 ++++----
>  arch/x86/kernel/doublefault.c    | 36 +++++++++++++++++-------------------
>  arch/x86/power/cpu.c             | 13 +++++++------
>  5 files changed, 31 insertions(+), 32 deletions(-)

With that:

Reviewed-by: Borislav Petkov <bp@xxxxxxx>

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)
--