Re: kernel CI: printk loglevels in kernel boot logs?

From: Kevin Hilman
Date: Wed Nov 22 2017 - 15:22:19 EST


On Wed, Nov 22, 2017 at 4:38 AM, Sergey Senozhatsky
<sergey.senozhatsky.work@xxxxxxxxx> wrote:
> On (11/22/17 12:34), Petr Mladek wrote:
> [..]
>> > > > This is espeically useful when ingesting kernel logs into advanced
>> > > > search/analytics frameworks (I'm playing with and ELK stack: Elastic
>> > > > Search, Logstash, Kibana).
> [..]
>> To make it clear. I understand that "show_loglevel" command line argument
>> would be useful for you. But I am afraid that it is not worth changing
>> the format. There would need to be wide interest into the change.
>> Also there would need to be evidence that the existing solutions
>> (dmesg --raw, console_loglevel) are not enough in many real life
>> scenarios.
>
> well, I think that that "consoles_format=syslog" command line parameter
> will be enabled only by those who actually want to have it - Fengguang's
> build robot and kernelCI (+ may be more setups). so I'd probably assume
> there are low risks here. may be I'm wrong.

Agreed. The goal of the command-line parameter is so that only
automation frameworks that would use it.

The other important reason for having this on the command line is that
for testing linux-next (and other bleeding edge developer branches),
it's common that we never make it to userspace, so can't even run
"dmesg --raw" (or equivalent.) So we really want this on the primary
boot (serial) console.

> I think it makes sense to have syslog's format "<%u>[timestamp] text\n"
> on serial consoles (time stamp when PRINTK_TIME set; <%u> when
> consoles_format=syslog set).

Yes, I think it should match "dmesg --raw".

Kevin