Re: [PATCH 1/2] ALSA: pcm: add SNDRV_PCM_FORMAT_{S, U}20_4

[Maciej S. Szmigiero]

On 23.11.2017 00:27, Takashi Sakamoto wrote:
> On Nov 23 2017 04:17, Maciej S. Szmigiero wrote:
(..)
>> --- a/include/uapi/sound/asound.h
>> +++ b/include/uapi/sound/asound.h
>> @@ -236,7 +236,11 @@ typedef int __bitwise snd_pcm_format_t;
>> Â #defineÂÂÂ SNDRV_PCM_FORMAT_DSD_U32_LEÂÂÂ ((__force snd_pcm_format_t) 50) /* DSD, 4-byte samples DSD (x32), little endian */
>> Â #defineÂÂÂ SNDRV_PCM_FORMAT_DSD_U16_BEÂÂÂ ((__force snd_pcm_format_t) 51) /* DSD, 2-byte samples DSD (x16), big endian */
>> Â #defineÂÂÂ SNDRV_PCM_FORMAT_DSD_U32_BEÂÂÂ ((__force snd_pcm_format_t) 52) /* DSD, 4-byte samples DSD (x32), big endian */
>> -#defineÂÂÂ SNDRV_PCM_FORMAT_LASTÂÂÂÂÂÂÂ SNDRV_PCM_FORMAT_DSD_U32_BE
>> +#defineÂÂÂ SNDRV_PCM_FORMAT_S20_4LEÂÂÂ ((__force snd_pcm_format_t) 53)ÂÂÂ /* in four bytes */
>> +#defineÂÂÂ SNDRV_PCM_FORMAT_S20_4BEÂÂÂ ((__force snd_pcm_format_t) 54)ÂÂÂ /* in four bytes */
>> +#defineÂÂÂ SNDRV_PCM_FORMAT_U20_4LEÂÂÂ ((__force snd_pcm_format_t) 55)ÂÂÂ /* in four bytes */
>> +#defineÂÂÂ SNDRV_PCM_FORMAT_U20_4BEÂÂÂ ((__force snd_pcm_format_t) 56)ÂÂÂ /* in four bytes */
>> +#defineÂÂÂ SNDRV_PCM_FORMAT_LASTÂÂÂÂÂÂÂ SNDRV_PCM_FORMAT_U20_4BE
> 
> In my opinion, for this type of definition, it's better to declare left/right-adjusted or padding side. (Of course, silence definition is already a hint, however the lack of information forces developers to have a careful behaviour to handle entries on the list.> (I note that in current ALSA PCM interface there's no way to deliver MSB/LSB-first information about sample format.)

No other sound format includes this information in its name so if we name
these formats SNDRV_PCM_FORMAT_{S, U}20LSB_4 they are going to have it
inconsistent with every other one (I assume you meant to include such
information in a format name?).

But information about whether this format is MSB or LSB justified can be
added in a comment so the situation is clear for other developers from
the definition without needing to read the actual processing code.

> Additionally, alsa-lib includes some codes related to the definition[1]. If you'd like to thing goes well out of ALSA SoC part, it's better to submit changes to the library as well.
> 
> [1] http://git.alsa-project.org/?p=alsa-lib.git;a=blob;f=src/pcm/pcm_misc.c;h=5420b1895713a3aec3624a5218794a7b49baf167;hb=HEAD

I have alsa-lib changes ready for these formats - they were needed to
test these patches, will post them when this is merged on the kernel
side (in case some changes are needed which affect both).

> Regards
> 
> Takashi Sakamoto

Best regards,
Maciej Szmigiero