Re: [PATCH 3.16 100/133] bcache: correct cache_dirty_target in __update_writeback_rate()

[Joe Perches]

On Thu, 2017-11-23 at 13:08 +0000, Ben Hutchings wrote:
> On Tue, 2017-11-21 at 19:41 -0800, Joe Perches wrote:
> > On Wed, 2017-11-22 at 01:58 +0000, Ben Hutchings wrote:
> > > 3.16.51-rc1 review patch.  If anyone has any objections, please let me know.
> > []
> > > --- a/drivers/md/bcache/writeback.h
> > > +++ b/drivers/md/bcache/writeback.h
> > > @@ -14,6 +14,25 @@ static inline uint64_t bcache_dev_sector
> > >  	return ret;
> > >  }
> > >  
> > > +static inline uint64_t  bcache_flash_devs_sectors_dirty(struct cache_set *c)
> > > +{
> > > +	uint64_t i, ret = 0;
> > 
> > There's no reason i should be uint64_t
> > as nr_uuids is unsigned int.
> 
> But this still works, right?  That's a minor issue to deal with
> upstream, not in the backport.

correct