Re: [PATCH v3 1/2] gpio: gpiolib: Generalise state persistence beyond sleep

[Linus Walleij]

On Wed, Nov 1, 2017 at 5:04 AM, Andrew Jeffery <andrew@xxxxxxxx> wrote:

> General support for state persistence is added to gpiolib with the
> introduction of a new pinconf parameter to propagate the request to
> hardware. The existing persistence support for sleep is adapted to
> include hardware support if the GPIO driver provides it. Persistence
> continues to be enabled by default; in-kernel consumers can opt out, but
> userspace (currently) does not have a choice.
>
> The *_SLEEP_MAY_LOSE_VALUE and *_SLEEP_MAINTAIN_VALUE symbols are
> renamed, dropping the SLEEP prefix to reflect that the concept is no
> longer sleep-specific.  I feel that renaming to just *_MAY_LOSE_VALUE
> could initially be misinterpreted, so I've further changed the symbols
> to *_TRANSITORY and *_PERSISTENT to address this.
>
> The sysfs interface is modified only to keep consistency with the
> chardev interface in enforcing persistence for userspace exports.
>
> Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>

This does not apply to the Torvalds master HEAD anymore
so please:

- Collect ACKs
- Rebase on Torvalds tree or v4.15-rc1 when it's out
- Resend

The functionality per se looks very nice :) so I want to apply this
ASAP.

Yours,
Linus Walleij