Re: [PATCH v2 4/6] ARM: dts: imx6qdl: Add Variscite DART-MX6 SoM support

[Fabio Estevam]

On Wed, Nov 22, 2017 at 9:02 AM, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote:

> +       reg_wl18xx_vmmc: regulator-wl18xx {
> +               compatible = "regulator-fixed";
> +               regulator-name = "vwl1807";
> +               regulator-min-microvolt = <1800000>;
> +               regulator-max-microvolt = <1800000>;
> +               gpio = <&gpio7 8 GPIO_ACTIVE_HIGH>;

Is this really GPIO_ACTIVE_HIGH?

If so, then a 'enable-active-high' property would be needed.

> +&hdmi {

No ddc-i2c-bus property?

> +       pinctrl_pmic: pmicgrp {
> +               fsl,pins = <
> +                       /* PMIC INT */
> +                       MX6QDL_PAD_GPIO_17__GPIO7_IO12          0x80000000

No 0x80000000 please. Use the real IOMUX value here instead.

> +&pcie {
> +       fsl,tx-swing-full = <103>;
> +       fsl,tx-swing-low = <103>;
> +       status = "disabled";

No 'reset-gpio' property?