Re: [PATCH v2] checkpatch: Add a warning for log messages that don't end in a new line
From: Logan Gunthorpe
Date: Sun Nov 26 2017 - 23:00:51 EST
On 26/11/17 03:29 PM, Joe Perches wrote:
> This proposal has a very high false positive rate.
The only actual false positive you've pointed out is the one that is
just incorrect in the wrong way (the author should have used a KERN_CONT
but did not). I could easily do something similar to what Julia proposes
and produce a different warning if the string ends in a space. But I
don't see any bullet proof way for any script to deduce what the author
actually meant.
> Keep at it though.
> Maybe something useful will be produced with more effort.
Unless there's more actually constructive criticism I don't think I'll
be getting any further with this.
Logan