Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

[Ian Abbott]

On 26/11/17 01:50, Alex Frappier Lachapelle wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Alex Frappier Lachapelle <Alex.FrappierLachapelle@xxxxxxxxx>
> ---
>   drivers/staging/comedi/drivers/das16.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/das16.c
> index ddd4aeab6365..ed1e9e9b651d 100644
> --- a/drivers/staging/comedi/drivers/das16.c
> +++ b/drivers/staging/comedi/drivers/das16.c
> @@ -967,7 +967,7 @@ static const struct comedi_lrange *das16_ai_range(struct comedi_device *dev,
>   
>   	/* get any user-defined input range */
>   	if (pg_type == das16_pg_none && (min || max)) {
> -		struct comedi_lrange *lrange;
> +		const struct comedi_lrange *lrange;
>   		struct comedi_krange *krange;
>   
>   		/* allocate single-range range table */

NAK.  The following lines of source code allocate memory pointed to by 
'lrange' and modify it, so 'const' is not appropriate here.

> @@ -1001,7 +1001,7 @@ static const struct comedi_lrange *das16_ao_range(struct comedi_device *dev,
>   
>   	/* get any user-defined output range */
>   	if (min || max) {
> -		struct comedi_lrange *lrange;
> +		const struct comedi_lrange *lrange;
>   		struct comedi_krange *krange;
>   
>   		/* allocate single-range range table */

Ditto.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx> )=-
-=(                          Web: http://www.mev.co.uk/  )=-