Re: [PATCH] net: openvswitch: datapath: fix data type in queue_gso_packets

[Gustavo A. R. Silva]

Quoting David Miller <davem@xxxxxxxxxxxxx>:

> From: Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx>
> Date: Sat, 25 Nov 2017 16:15:01 -0500
>
> > On Sat, Nov 25, 2017 at 2:14 PM, Gustavo A. R. Silva
> > <garsilva@xxxxxxxxxxxxxx> wrote:
> > > gso_type is being used in binary AND operations together with SKB_GSO_UDP.
> > > The issue is that variable gso_type is of type unsigned short and
> > > SKB_GSO_UDP expands to more than 16 bits:
> > >
> > > SKB_GSO_UDP = 1 << 16
> > >
> > > this makes any binary AND operation between gso_type and SKB_GSO_UDP to
> > > be always zero, hence making some code unreachable and likely causing
> > > undesired behavior.
> > >
> > > Fix this by changing the data type of variable gso_type to unsigned int.
> > >
> > > Addresses-Coverity-ID: 1462223
> > > Fixes: 0c19f846d582 ("net: accept UFO datagrams from tuntap and packet")
> > > Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
> >
> > Acked-by: Willem de Bruijn <willemb@xxxxxxxxxx>
>
> Applied and I'll queued this up with Willem's changes for -stable.
>
> Thanks!

Glad to help :)

Thanks
--
Gustavo A. R. Silva