Re: [PATCH v2 29/35] dt-bindings: nds32 CPU Bindings

[Greentime Hu]

2017-11-27 21:42 GMT+08:00 Mark Rutland <mark.rutland@xxxxxxx>:
> Him
>
> On Mon, Nov 27, 2017 at 08:28:16PM +0800, Greentime Hu wrote:
>> From: Greentime Hu <greentime@xxxxxxxxxxxxx>
>>
>> This patch adds nds32 CPU binding documents.
>>
>> Signed-off-by: Vincent Chen <vincentc@xxxxxxxxxxxxx>
>> Signed-off-by: Rick Chen <rick@xxxxxxxxxxxxx>
>> Signed-off-by: Zong Li <zong@xxxxxxxxxxxxx>
>> Signed-off-by: Greentime Hu <greentime@xxxxxxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/nds32/cpus.txt |   32 ++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/nds32/cpus.txt
>>
>> diff --git a/Documentation/devicetree/bindings/nds32/cpus.txt b/Documentation/devicetree/bindings/nds32/cpus.txt
>> new file mode 100644
>> index 0000000..c302c89
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/nds32/cpus.txt
>> @@ -0,0 +1,32 @@
>> +* Andestech Processor Binding
>> +
>> +This binding specifies what properties must be available in the device tree
>> +representation of a Andestech Processor Core, which is the root node in the
>> +tree.
>> +
>> +Required properties:
>> +
>> +     - compatible:
>> +             Usage: required
>> +             Value type: <string>
>> +             Definition: should be one of:
>> +                     "andestech,n13"
>> +                     "andestech,n15"
>> +                     "andestech,d15"
>> +                     "andestech,n10"
>> +                     "andestech,d10"
>> +                     "andestech,nds32v3"
>
> Are these specific parts, or architecture versions?
>
> I guess "andestech,nds32v3" is an architecture version, and the rest are
> specific parts?

Yes, nds32v3 is an architecture version and the rest are nds32v3
compatible processor's name.

>> +     - device_type
>> +             Usage: required
>> +             Value type: <string>
>> +             Definition: must be "cpu"
>> +     - clock-frequency: Contains the clock frequency for CPU, in Hz.
>> +
>> +* Examples
>> +
>> +/ {
>> +     cpu {
>> +             device_type = "cpu";
>> +             compatible = "andestech,n13", "andestech,nds32v3";
>> +     };
>
> This is missing the required clock-frequency property.
>
> There should be a /cpus node, with each CPU listed under that, to align
> with the devicetree spec. Even if you never support SMP, there's no
> reason to be different from other architectures.
>
> You should have something like:
>
> / {
>         cpus {
>                 cpu {
>                         device_type = "cpu";
>                         compatible = "andestech,n13";
>                         clock-frequency = <...>;
>                 };
>         };
> };
>
> Thanks,
> Mark.

Thanks.
I will modify it in the next version patch.