Re: [PATCH] mm/vmscan: change return type of is_page_cache_freeable from int to bool

[Michal Hocko]

On Tue 28-11-17 10:48:27, Jiang Biao wrote:
> Using bool for the return type of is_page_cache_freeable() should be
> more appropriate.

Does this help to generate a better code or why do we want to change
this at all?

> Signed-off-by: Jiang Biao <jiang.biao2@xxxxxxxxxx>
> ---
>  mm/vmscan.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index eb2f031..5fe63ed 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -530,7 +530,7 @@ void drop_slab(void)
>  		drop_slab_node(nid);
>  }
>  
> -static inline int is_page_cache_freeable(struct page *page)
> +static inline bool is_page_cache_freeable(struct page *page)
>  {
>  	/*
>  	 * A freeable page cache page is referenced only by the caller
> -- 
> 2.7.4
> 

-- 
Michal Hocko
SUSE Labs