Re: [PATCH v2] usb: dwc2: host: Don't retry NAKed transactions right away
From: Doug Anderson
Date: Tue Nov 28 2017 - 11:07:53 EST
Hi,
On Tue, Nov 28, 2017 at 6:37 AM, Stefan Wahren <stefan.wahren@xxxxxxxx> wrote:
> Hi Doug,
>
> Doug Anderson <dianders@xxxxxxxxxxxx> hat am 30. Oktober 2017 um 18:14
> geschrieben:
>
> Hi,
>
> On Mon, Oct 30, 2017 at 1:32 AM, Felipe Balbi <balbi@xxxxxxxxxx> wrote:
>>
>
> Hi,
>
> Doug Anderson <dianders@xxxxxxxxxxxx> writes:
>
> Hi,
>
> On Sat, Oct 28, 2017 at 8:51 AM, Stefan Wahren <stefan.wahren@xxxxxxxx>
> wrote:
>
> Hi Doug,
>
> [add Felipe since this should go through his tree]
>
> Ah. Sorry Felipe! I know you've landed some dwc2 stuff in the past
>
> No problems :-)
>
> but for some reason get_maintainer didn't ID you so I thought maybe
> you weren't doing it anymore. Please let me know if you'd like me to
> send this to you again with collected Reviewed-by and Tested-by tags.
>
> Yeah, please resend with all tags collected, however let's wait for a
> week or so and give other people time to catch up. I already sent my
> pull request to Greg, this would, anyway, go into the -rc cycle.
>
> Doh! I just re-read this one more time (after sending v3) and
> realized I had read it incorrectly. I read it as "please send the
> patch with the tags and I'll wait a week before landing", but you
> actually said "please wait a week before re-sending". Sorry for the
> noise. In the very least, you should be on the "To" line now so if
> anyone else has any extra tags it should be very easy for you to see
> them.
>
> Right that there's no massive urgency. It's been broken forever.
>
> since 4.15rc1 is out, how are your plans for the next Patch version?
Yeah, I was going to wait a week or so before pestering Felipe since
some people are still in Thanksgiving holiday mode and rc1 _just_ came
out... My understanding is that the existing v3 patch is OK as-is and
I wasn't planning to send another one. patchwork.kernel.org IDs for
the most recent version:
10032939 New [v3,1/2] usb: dwc2: host: Don't retry NAKed
transactions right away
10032935 New [v3,2/2] usb: dwc2: host: Convert hcd_queue to timer_setup
-Doug