Re: [PATCH] lib: zstd: bitstream: Mark expected switch fall-throughs

From: Nick Terrell
Date: Tue Nov 28 2017 - 16:39:20 EST

Next message: Matthew Wilcox: "[PATCH 17/17] idr: Warn if old iterators see large IDs"
Previous message: Matthew Wilcox: "[PATCH 03/17] idr test suite: Fix ida_test_random()"
In reply to: Gustavo A. R. Silva: "[PATCH] lib: zstd: bitstream: Mark expected switch fall-throughs"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> On Nov 27, 2017, at 4:00 PM, Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx> wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>

Looks good to me. We had the same patch in upstream PR#690 [1].
I believe that PR#695 [2] was also necessary to quiet the warning.

[1] https://github.com/facebook/zstd/pull/690/files
[2] https://github.com/facebook/zstd/pull/695/files

Reviewed-by: Nick Terrell <terrelln@xxxxxx>

Next message: Matthew Wilcox: "[PATCH 17/17] idr: Warn if old iterators see large IDs"
Previous message: Matthew Wilcox: "[PATCH 03/17] idr test suite: Fix ida_test_random()"
In reply to: Gustavo A. R. Silva: "[PATCH] lib: zstd: bitstream: Mark expected switch fall-throughs"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]