Re: [PATCH] phy: rockchip-typec: add pm_runtime_disable in err case

[Doug Anderson]

Hi,

On Thu, Sep 8, 2016 at 10:38 AM, Chris Zhong <zyw@xxxxxxxxxxxxxx> wrote:
> Add pm_runtime_disable in err case to make the pm_runtime_enable/disable
> is invoked balanced.
>
> Signed-off-by: Chris Zhong <zyw@xxxxxxxxxxxxxx>
>
> ---
>
>  drivers/phy/phy-rockchip-typec.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/phy-rockchip-typec.c b/drivers/phy/phy-rockchip-typec.c
> index 7cfb0f8..dd257c7 100644
> --- a/drivers/phy/phy-rockchip-typec.c
> +++ b/drivers/phy/phy-rockchip-typec.c
> @@ -977,6 +977,7 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
>                 if (IS_ERR(phy)) {
>                         dev_err(dev, "failed to create phy: %s\n",
>                                 child_np->name);
> +                       pm_runtime_disable(dev);
>                         return PTR_ERR(phy);
>                 }
>
> @@ -986,6 +987,7 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev)
>         phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
>         if (IS_ERR(phy_provider)) {
>                 dev_err(dev, "Failed to register phy provider\n");
> +               pm_runtime_disable(dev);
>                 return PTR_ERR(phy_provider);
>         }
>
> --
> 1.9.1

The patch is a little stale, but it still tastes OK to me.  Maybe a
good time to land it?  :-P

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

-Doug