Re: [PATCH 1/1] usb: gadget: u_serial: Use kfifo instead of homemade circular buffer

From: Lu Baolu
Date: Tue Nov 28 2017 - 18:34:12 EST


Hi Felipe,

On 11/28/2017 04:05 PM, Felipe Balbi wrote:
> Hi,
>
> Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx> writes:
>> The kernel FIFO implementation, kfifo, provides interfaces to manipulate
>> a first-in-first-out circular buffer. Use kfifo instead of the homemade
>> one to make the code more concise and readable.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> Thanks :-) Can you give a little description of how you tested this?
>

I tested it on an Intel Skylake box. On the gadget side, I loaded a serial
device (#modprobe g_serial). And then, connected it with a host.

On the gadget side, I run below scripts:

#!/bin/bash

for j in `seq 1 200`;
do
for i in `seq 1 50000`;
do
echo $i.$j > /dev/ttyGS0
done
done

And, on the host side,

#cat /dev/ttyACM0

Best regards,
Lu Baolu