Re: [PATCH v2] ARM64: crypto: do not call crypto_unregister_skcipher twice on error

From: Herbert Xu
Date: Wed Nov 29 2017 - 01:40:57 EST


On Fri, Nov 24, 2017 at 08:22:07AM +0000, Corentin Labbe wrote:
> When a cipher fails to register in aes_init(), the error path goes thought
> aes_exit() then crypto_unregister_skciphers().
> Since aes_exit calls also crypto_unregister_skcipher, this triggers a
> refcount_t: underflow; use-after-free.
>
> Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx>

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt