Re: [PATCH v2 4/4] backlight: as3711_bl: fix device-tree node leaks

From: Lee Jones
Date: Wed Nov 29 2017 - 06:29:34 EST


On Mon, 20 Nov 2017, Johan Hovold wrote:

> Two framebuffer device-node names were looked up during probe, but were
> only used as flags to indicate the presence of two framebuffer device.
>
> Drop the unused framebuffer name along with a likewise unused device
> pointer from the driver data, and update the platform data to pass in
> booleans instead of the framebuffer strings. This allows us do drop the
> node references acquired during probe, which would otherwise leak.
>
> Note that there are no other in-kernel users of the modified
> platform-data fields.
>
> Fixes: 59eb2b5e57ea ("drivers/video/backlight/as3711_bl.c: add OF support")
> Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> ---
> drivers/video/backlight/as3711_bl.c | 12 ++++++------
> include/linux/mfd/as3711.h | 4 ++--
> 2 files changed, 8 insertions(+), 8 deletions(-)

Applied, thanks.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog